Mike Myers
05/02/2022, 6:31 PMseph
05/02/2022, 9:52 PMseph
05/02/2022, 11:42 PMMike Myers
06/01/2022, 4:19 PMkernel_panics
is not that big, but generating kernel panic logs is annoying so I've attached sample files so the reviewer can test or just check how they look. https://github.com/osquery/osquery/pull/7585Daniel Bretón Suárez
06/02/2022, 7:56 AMnp5
06/28/2022, 3:44 PMnp5
06/28/2022, 3:44 PMnp5
06/28/2022, 4:24 PMLucas Rodriguez
08/02/2022, 10:00 PMAndre Pinter
08/29/2022, 6:22 PMdiff --git a/osquery/tables/forensic/carves.cpp b/osquery/tables/forensic/carves.cpp
index 1fcdb25af..80929ad13 100644
--- a/osquery/tables/forensic/carves.cpp
+++ b/osquery/tables/forensic/carves.cpp
@@ -53,8 +53,10 @@ void enumerateCarves(QueryData& results, const std::string& new_guid) {
r["time"] = INTEGER(tree.doc()["time"].GetUint64());
}
- if (tree.doc().HasMember("size")) {
+ if (tree.doc().HasMember("size") && tree.doc()["size"].IsInt()) {
r["size"] = INTEGER(tree.doc()["size"].GetInt());
+ } else if (tree.doc().HasMember("size") && tree.doc()["size"].IsString()) {
+ r["size"] = INTEGER(tree.doc()["size"].GetString());
}
stringToRow("sha256", r, tree);
From reading more of the codebase and the database code it seems like there's some friction where the update functions only take strings and then it seems its up to casts elsewhere in the codebase to turn them into the right typesMike Myers
08/30/2022, 5:50 AMMike Myers
08/30/2022, 5:52 AMLucas Rodriguez
09/06/2022, 10:37 PMMike Myers
09/16/2022, 4:44 PMMike Myers
09/26/2022, 4:08 PMArtemis Tosini
09/29/2022, 4:10 PMLucas Rodriguez
10/19/2022, 6:54 PMBrad Girardeau
10/28/2022, 2:52 AMStefano Bonicatti
11/10/2022, 12:45 PMzwass
12/02/2022, 1:44 AMzwass
12/02/2022, 1:45 AMzwass
12/02/2022, 1:45 AMzwass
12/02/2022, 1:45 AMzwass
12/02/2022, 1:46 AMArtemis Tosini
12/08/2022, 10:07 PMzwass
02/01/2023, 12:42 AMzwass
02/04/2023, 2:39 PMLucas Rodriguez
03/17/2023, 7:42 PMJames Pickett
04/14/2023, 6:00 PMwindows_search
table that lets users query windows using CCommand via osquery. This is my first attempt at contributing to osquery and my first real foray into C++. Would love some preliminary feedback, just to validate my approach and ensure my code is in the ball park in terms of quality.zwass
04/25/2023, 5:02 PM