It’s supposed to be Mac-compliant, and it’s obviou...
# macosa
allister
10/09/2023, 11:17 AMIt’s supposed to be Mac-compliant, and it’s obviously showing names, I’d next be looking at the schema for hints
p
Priya Jagyasi
10/09/2023, 3:47 PMThe schema does not give information about what can be the possible values...other table schemas however show the case when -1 can be the value...also not sure why the value is of type text since it is the power in Watts
s
Stefano Bonicatti
10/09/2023, 4:10 PMSometimes the schema is a bit lax (or an empty value is intentionally accepted).
It's -1 because the value type is not recognized; the value is encoded and needs to be decoded, and osquery is failing.
I also see we are missing keys.
Stefano Bonicatti
10/09/2023, 4:33 PMah we have an issue tracking this https://github.com/osquery/osquery/issues/5896
👍 2
☝️ 1
p
Priya Jagyasi
10/10/2023, 5:12 AMThanks Stefano...the issue seems to have opened long back..any possibility of the fix coming out sooner?
Priya Jagyasi
10/11/2023, 2:29 PM@Stefano Bonicatti I couldn't find power_sensors.cpp under osquery tables -> system -> darwin...am I looking at the correct place or ?
s
Stefano Bonicatti
10/11/2023, 2:48 PMIt's here: https://github.com/osquery/osquery/blob/8e8d596564e981ddac689e2d772f56fdf6ba25ec/osquery/tables/system/darwin/smc_keys.cpp#L617
As for the osquery development, it's fueled by voluntary work or companies (osquery users) paying third party developers.
So if that has not been tackled it means that there isn't enough interest unfortunately for now.
The project always welcomes PRs, keeping in mind that reviewing PRs takes time too so the simpler they are, with tests etc, the higher the chances they get looked at and merged in a reasonable time.
👍 1
5 Views