Title
#general
c

cssmason

04/03/2022, 7:26 AM
@seph I want to enhance this request. https://github.com/osquery/osquery-go/issues/95 Could I open a pull request directly?
zwass

zwass

04/04/2022, 1:12 AM
I'm happy to help review. I don't think I understand the issue completely, but it might help to just see the code.
s

seph

04/04/2022, 1:14 AM
I was thinking that would be a great thing to add!
1:14 AM
You are welcome to open a PR. Zach and/or myself will likely review
1:15 AM
If I remember, this will probably require updating
osquery.InternalExtensionInfo
and that whatever registers them all
1:37 AM
core
c

cssmason

04/04/2022, 4:31 AM
Hi, I want to push the branch to osquery-go, but it seems that I have no permission. Could you grant the permission for me?
Stefano Bonicatti

Stefano Bonicatti

04/04/2022, 10:24 AM
@cssmason you should fork the project and open a PR from your own branch
c

cssmason

04/04/2022, 10:50 AM
okay, I understood. Please help to review it. Thanks a lot.https://github.com/osquery/osquery-go/pull/96
1:05 PM
@seph @zwass Please help to review it. Thanks a lot.
11:59 AM
@zwass Hi Zach, I have completed another version. Please help to review it again. Thanks a lot.https://github.com/osquery/osquery-go/pull/97
s

seph

04/07/2022, 4:21 PM
Why make a new PR, and not update the old? It’s fine — we’ll look at the new one. But a more usual GitHub process would be to simply update the first one