Channels
doorman
zercurity
infrastructure
code-review
queryhub
apple-silicon
carving
goquery
aws
querycon
golang
file-carving
fuzzing
help-proxy
darkbytes
process-auditing
general
windows
random
fleet-dev
tls
fim
awallaby
zentral
zeek
auditing-warroom
linen-dev
fleetosquery
plugins
jobs
arm-architecture
uptycs
android_tests
selfgroup
vendor-feeds
fleet
eclecticiq-polylogyx-extension
ebpf
website
core
macos
kolide
osctrl
extensions
foundation
sql
officehours
linux
community-feeds
Powered by
#general
Title
# general
c
cssmason
04/03/2022, 7:26 AM
@seph
I want to enhance this request.
https://github.com/osquery/osquery-go/issues/95
Could I open a pull request directly?
z
zwass
04/04/2022, 1:12 AM
I'm happy to help review. I don't think I understand the issue completely, but it might help to just see the code.
s
seph
04/04/2022, 1:14 AM
I was thinking that would be a great thing to add!
You are welcome to open a PR. Zach and/or myself will likely review
If I remember, this will probably require updating
osquery.InternalExtensionInfo
and that whatever registers them all
core
c
cssmason
04/04/2022, 4:31 AM
Hi, I want to push the branch to osquery-go, but it seems that I have no permission. Could you grant the permission for me?
s
Stefano Bonicatti
04/04/2022, 10:24 AM
@cssmason
you should fork the project and open a PR from your own branch
c
cssmason
04/04/2022, 10:50 AM
okay, I understood. Please help to review it. Thanks a lot.
https://github.com/osquery/osquery-go/pull/96
@seph
@zwass
Please help to review it. Thanks a lot.
@zwass
Hi Zach, I have completed another version. Please help to review it again. Thanks a lot.
https://github.com/osquery/osquery-go/pull/97
s
seph
04/07/2022, 4:21 PM
Why make a new PR, and not update the old? It’s fine — we’ll look at the new one. But a more usual GitHub process would be to simply update the first one
5 Views
Post