Join Slack
Powered by
<@U0612BKF989> What’s your thought on these two PR...
# core
s
seph
08/12/2024, 7:40 PM
@Victor Lyuboslavsky
What’s your thought on these two PRs? Do we need them both?
l
Lucas Rodriguez
08/12/2024, 8:42 PM
Hi folks! Are they related? (I know they touch the same part of the code, but they seem different issues?) Invalid symlinks vs. a "Permission denied"?
s
seph
08/12/2024, 8:42 PM
They feel related, in that they both swap the boost stuff to the non-blocking form
l
Lucas Rodriguez
08/12/2024, 8:43 PM
Ah gotcha.
s
seph
08/12/2024, 8:48 PM
I guess 8392 adds the non-throw everywhere. Where. 8399 adds it more narrowly, and also adds canonicalization routines.
seph
08/12/2024, 8:48 PM
So maybe I should get 8399 merged, and then rebase 8392 and clean it up
➕ 1
l
Lucas Rodriguez
08/12/2024, 8:51 PM
Agree, 8399 is more of an addition than swapping.
s
seph
08/12/2024, 11:34 PM
@Lucas Rodriguez
You left a handful of comments on the tests in 8399. That feels like something that should get resolved before merge?
l
Lucas Rodriguez
08/12/2024, 11:46 PM
+1, let's wait for Victor to comment on those.
v
Victor Lyuboslavsky
08/13/2024, 6:20 AM
I replied to comments and updated tests.
@seph
the PR is ready to merge.
l
Lucas Rodriguez
08/13/2024, 9:12 AM
LGTM 👍
4
Views
Open in Slack
Previous
Next