<@U0612BKF989> What’s your thought on these two PR...
# core
s
@Victor Lyuboslavsky What’s your thought on these two PRs? Do we need them both?
l
Hi folks! Are they related? (I know they touch the same part of the code, but they seem different issues?) Invalid symlinks vs. a "Permission denied"?
s
They feel related, in that they both swap the boost stuff to the non-blocking form
l
Ah gotcha.
s
I guess 8392 adds the non-throw everywhere. Where. 8399 adds it more narrowly, and also adds canonicalization routines.
So maybe I should get 8399 merged, and then rebase 8392 and clean it up
1
l
Agree, 8399 is more of an addition than swapping.
s
@Lucas Rodriguez You left a handful of comments on the tests in 8399. That feels like something that should get resolved before merge?
l
+1, let's wait for Victor to comment on those.
v
I replied to comments and updated tests. @seph the PR is ready to merge.
l
LGTM 👍