So first of all, thanks! ❤️ A couple of things that come to mind is that maybe some of those headers make assumption on the position of the other headers that were in the same directory, including them with

#include ""

instead of

#include <>

, but you should be able to notice it when you build. Second, there's a

osquery_headers

target that was meant to share that include folder afaik, though in Buck it was also carrying other dependencies with it, because you couldn't always use those headers alone; this has been carried over. So, I think that target has to be removed.. and if there are cases where only some defintions in the header are necessary, but no function definition, then the header should be split.. to avoid creating unnecessary dependencies.