Any thoughts on removing the "Dismiss stale pull r...
# core
t
Any thoughts on removing the "Dismiss stale pull request approvals when new commits are pushed" option? It is currently enabled and this seems incorrect. For example if we approve a PR with a comment like 'please edit this one thing' then we need to re-review the PR again if the person does take the time to update. I feel like this in theory de-incentivizes making the small or nitpick changes if you already have an approval. But in practice, only contributors can merge pull requests so regardless of the approve/request-changes decision, you need to request or hope a contributor hit the merge button. So then this toggle mostly effects contributors reviewing each other's code. If we trust each other to follow up on suggested changes and only issue approvals if the code looks accurate and we have no blocking changes/questions then I suggest we remove this option.