Curious about people’s thoughts on disabling “Dismiss stale pull request approvals when new commits are pushed” on GitHub?
I find myself often approving a PR, let’s say for another osquery committer with some minor nitpick feedback. When they apply that feedback the review is dismissed and they are blocked from merging. I don’t like the fact that they are blocked.
What could go wrong? They don’t apply the feedback: that’s ok, I approved knowing it would be fine either way and with a certain amount of trust. Seems acceptable to me.