Title
#core
s

seph

02/04/2022, 3:47 PM
@Stefano Bonicatti I think I’m ready to cut 5.2.2. Do you want to try to come to resolution on #7474 before?
Stefano Bonicatti

Stefano Bonicatti

02/04/2022, 4:24 PM
There doesn’t seem to be consensus about that choice and we really have spoken briefly me and you about that, so I guess that kind of choice can be done on a blueprint. I’m still slightly concerned though by the high default graceful time period, which is really meant for the normal shutdown workflow. Would a solution where we keep the “force” logic for the resource limit kill, but we wait 4 seconds for the graceful kill and then forcefully kill. 4 seconds is about the time osquery was waiting before we have changed the alarm timeout.
4:25 PM
This way osquery has “some” time to shutdown cleanly, but we also don’t wait too much. And it’s lower than what it’s currently achievable with lowering the
alarm_timeout
, which should be left alone.
s

seph

02/04/2022, 4:25 PM
Maybe a 4s grace is enough? That feels like enough that an unwedged process should be able to checkpoint.
4:27 PM
I feel like it would be to get some fix in, but also that it’s a bug that predates 5.2, so maybe we don’t need to hold a prerelease for it.
Stefano Bonicatti

Stefano Bonicatti

02/04/2022, 4:28 PM
Well, lets shift all of this to the 5.3.0 then
s

seph

02/04/2022, 4:28 PM
Okay! I’ll cut 5.2.2 later today, and we’ll see if we like it