Skimming that PR, it looks fine. Thoguh it feels weird having the destination set that way. But 🤷 I try not to get into the cmake weeds. Do you want to thumb and merge? Should I? (I am vigorously deferring to you here)

You mean the

/usr/bin

destination? So DESTINATION is always a folder, you can’t rename a file while installing. Also you put the path where you want those files to land when it’s installed by the end user on the system, because CPack takes care to internally prepend it’s own staging folder path when preparing the package. If you think it’s ok then lets merge it 🙂

Mostly... it feels like we're orienting wrong? Like

usd/bin

is just for the synlinks. But it's being declared with a name that implies it's the destination. (Vs opt/osquery)

I see what you mean, yeah it’s that those source files in FILES are the symlinks, they have been just created in the build folder of the osquery-packaging repo (CMAKE_CURRENT_BINARY_DIR), while the actual binaries are under OSQUERY_DATA_PATH, which is a different path. Anyway I’ll merge it then.

Exactly. It's just a bit about naming and implications.