Title
#core
s

seph

12/02/2021, 6:26 PM
Skimming that PR, it looks fine. Thoguh it feels weird having the destination set that way. But 🤷 I try not to get into the cmake weeds. Do you want to thumb and merge? Should I? (I am vigorously deferring to you here)
Stefano Bonicatti

Stefano Bonicatti

12/02/2021, 8:06 PM
You mean the
/usr/bin
destination? So DESTINATION is always a folder, you can’t rename a file while installing. Also you put the path where you want those files to land when it’s installed by the end user on the system, because CPack takes care to internally prepend it’s own staging folder path when preparing the package. If you think it’s ok then lets merge it 🙂
s

seph

12/02/2021, 8:09 PM
Mostly... it feels like we're orienting wrong? Like
usd/bin
is just for the synlinks. But it's being declared with a name that implies it's the destination. (Vs opt/osquery)
8:09 PM
But I think it's fine? Just confusing to me
8:09 PM
But I try to avoid cmake
8:09 PM
I'm deferring to you -- if you're good I am
Stefano Bonicatti

Stefano Bonicatti

12/02/2021, 8:11 PM
I see what you mean, yeah it’s that those source files in FILES are the symlinks, they have been just created in the build folder of the osquery-packaging repo (CMAKE_CURRENT_BINARY_DIR), while the actual binaries are under OSQUERY_DATA_PATH, which is a different path. Anyway I’ll merge it then.
s

seph

12/03/2021, 1:01 AM
Exactly. It's just a bit about naming and implications.
1:01 AM
Cool. So if that merged we probably need a sha bump ?