hello Fleet team . Was wondering if there’s any interest in the following as a feature request:basically pubsub snapshot logger is ok but
would anyone be interested in implementing an option to split it into separate event per snapshot log row so to speakI’m kinda 50/50 if it’s done here https://github.com/fleetdm/fleet/blob/main/server/logging/pubsub.go#L59 well more specifically here https://github.com/fleetdm/fleet/blob/main/server/logging/pubsub.go#L93 something like generate a GUID and split the event rows into separate Pub sub messages as well . (and duplicate all metadata for each message - it’s fine better than complicating it query level)as in we’d check if the snapshot event has multiple rows and transform it into several messages and publish them
xD I’d do a PR but i know 0 things about go, and then you might reject it 😄
this makes it a lot easier to work on events with multiple snapshot rows at query level.
ps and sure we can make that happen with makemv and mvexpand etc but it’s just cleaner if it’s nice small json per row per event at least imo. instead of trying to parse 100k json (default char limit of 10,000 chars gets hit pretty quickly too)
08/17/2022, 2:35 PM
Thanks for the feature suggestion! If you'd like to submit an issue for it on Github, I can take it to the team to see if it's something we can prioritize. You're always welcome to submit a pull request as well if that's something you find fun 🙂