https://github.com/osquery/osquery logo
Join Slack
Powered by
Does anyone have access to be able to run a build ...
# core
k
Does anyone have access to be able to run a build for a PR branch? https://github.com/osquery/osquery/pull/8504
@Stefano Bonicatti - classic, forgot to run the 
cmake --build . --target format
before pushing 🤦
Is there a possibility to trigger another build
or will it work automatically from now on?
s
Got it 🙂. No, until you have your first merge it will still block it
k
👍
RE: your comment about selecting c++17 for windows. https://github.com/osquery/osquery/pull/8504#issuecomment-2573545455 Is that worthy as another PR? I am unsure where we select the particular version of c++. But I figured upgrading might be nice?
i side stepped the issue to try to get this particular fix in
s
Sorry I think I was not fully thinking of your setup and somehow assumed you were building not through osquery CMake. So C++17 should be configured correctly there, so it should be present as long as then you also include the header. We are already using a variant on Windows code, so it should work.
Was it failing to compile even with the 
#include <variant>
directive?
k
I did try that 
#include
and curiously enough it passes on when i build on mac
honestly, the struct approach I used isn't that bad. It cleans up the method signature significantly. And doesn't really have any memory or type checking issues in addition. So I'm ok with using it
I mean..
Copy code
std::vector<std::map<std::string, std::variant<std::int64_t, std::string>>>
vs
Copy code
std::vector<std::map<std::string, UserPath>>
anyone around to kick a build off for this PR?
10 Views
Open in Slack
PreviousNext
Powered by