Hey Folks, is there a reason the mysql table `vuln...
# fleetc
Camilo
01/06/2025, 10:08 PMHey Folks, is there a reason the mysql table
vulnerability_host_countsk
Kathy Satterlee
01/06/2025, 11:05 PMHi @Camilo We didn't explicitly set a primary key on this table since we're always pulling data based on the values covered by the unique key.
c
Camilo
01/08/2025, 12:08 AMThanks for explaining! I understand the reliance on the unique key, but I believe it's a good practice to set a primary key, especially for larger tables. In MySQL with InnoDB, primary keys are critical for performance optimization, data integrity, and scalability. Even if not immediately necessary, they can prevent potential issues in the future, such as replication or migration challenges.
Camilo
01/08/2025, 12:09 AMDo you have any idea if something like this would work? Our main concerns is breaking the upgrade process if we start making changes directly in the DB.
k
Kathy Satterlee
01/08/2025, 3:26 PMI would definitely never recommend modifying the database directly.
Kathy Satterlee
01/08/2025, 3:27 PMThis is excellent feedback though! Would you be up for submitting a GitHub ticket with your suggestion?
c
Camilo
01/09/2025, 1:41 AM100%. Just a new issue?
Camilo
01/09/2025, 2:30 AM@Kathy Satterlee I don't believe this is a bug on itself.. so I'm thinking maybe a FR?
Camilo
02/04/2025, 1:18 AMClosing the loop on this one: Heres the feature request: https://github.com/fleetdm/fleet/issues/26006
2 Views