I'm missing today again. :disappointed:
But I mad...
# officehourss
seph
03/11/2025, 1:31 PM
I'm missing today again. 😞
But I made you an agenda doc! https://hackmd.io/K_0nlyc4S82IzbmsaIMR2A
g
Guillaume Winter
03/11/2025, 1:48 PMHey folks,
Anything I can do to help moving forward https://github.com/osquery/osquery/pull/8520 ? 🤔
s
seph
03/11/2025, 1:49 PM
I'll try to get it reviewed before the next release. (I wanted to get 5.16 cut in a bit of a hurry to mitigate a bug in the wild)
seph
03/11/2025, 1:49 PM
I think we still don't have any kind of simpler approach. So the cpomplexity feels inherent.
g
Guillaume Winter
03/11/2025, 1:51 PMHappy to split it if it helps, or to do it completely differently if y'all have strong feelings 😉
Also happy to discuss it synchronously if it can help, but unfortunately the Office Hours timing is terrible for me 😕
z
zwass
03/11/2025, 5:46 PM
@Guillaume Winter I made a minor change request -- after we address that I think it's good to merge.
g
Guillaume Winter
03/11/2025, 9:22 PMthanks a ton @zwass. Looking at it ASAP, and will update you when it's done.
Thanks again
Guillaume Winter
03/12/2025, 1:33 PM@zwass: change made, PR is all green 🥳
Guillaume Winter
03/25/2025, 1:39 PM@zwass: when you find time to take a look at https://github.com/osquery/osquery/pull/8520 , I'd happily take any more feedback that y'all would have to try to make it better. 🙏
z
zwass
03/25/2025, 5:00 PM
Merged now 🙂 Thank you!
4 Views