Hi folks! A couple of recent CI failures: - <https...
# core
s
Hi folks! A couple of recent CI failures: • https://github.com/osquery/osquery/pull/8697 -- Linux free space, should work. • https://github.com/osquery/osquery/pull/8698 -- Starting to try to fix windows perl issues. Need to see how CI does.
1
Okay, these both passed the appropriate parts of their CI. I think we should merge the linux one over the windows failures, and the windows one over the linux failures. (Thought the windows one needs another hour to re-run)
@Stefano Bonicatti Do you know any reason we can't remove Strawberry Perl (eg: please review) Or @zwass also good for review
s
Perl is needed to build the OpenSSL library, their build system uses it.
s
Build works without that. I think Perl is already on the runners. Do you think we need that one explicitly?
s
Looking at your PR it seems the very same version is already installed.
So it's not necessary to install it ourselves anymore
s
And if it was missing the build would fail, right? Nor build with the wrong OpenSSL or something?
s
Yeah correct; you can see in this Windows job (https://github.com/osquery/osquery/actions/runs/18311030729/job/52139489676?pr=8698), the
Configure the project
step, near start-ish has:
Copy code
-- Importing formula: formula/openssl
-- Found Perl: C:/Strawberry/perl/bin/perl.exe (found version "5.32.1")
Which is done by this part: https://github.com/osquery/osquery/blob/master/libraries/cmake/formula/openssl/CMakeLists.txt#L137-L138
s
Excellent. Then that should fix windows ci
You could thumb it. I’ll merge over the Linux failures.
Ah, Lucas approved. I merged them. I'll see about restarting the other PRs
z
Thanks y'all for handling this!