as for cpuid ... should I completely remove creati...
# generalb
Benjamin Herrenschmidt
08/26/2020, 3:54 AMas for cpuid ... should I completely remove creation of the table ? currently I think we create an empty onne ...
s
seph
08/26/2020, 4:50 AM
I swear we talked about this case in office hours, but my minutes are unclear.
For the tables that you can’t create we should create a ticket for followup.
I’m less sure if we should create a noop table that returns no rows, this would allow for better cross platform compatibility. Or no table and let it throw an error. I might vote for noops and tickets
b
Benjamin Herrenschmidt
08/26/2020, 4:52 AM"noops and tickets" what do you mean ?
Benjamin Herrenschmidt
08/26/2020, 4:52 AMArtemis original patch created an empty table, I found it simpler/cleaner to just not build the thing at all
Benjamin Herrenschmidt
08/26/2020, 4:52 AMbut I can revert back to what he did
Benjamin Herrenschmidt
08/26/2020, 5:00 AMAh .. "ticket" you mean open a github issue ?
s
seph
08/26/2020, 12:43 PM
Yes, open an github issue. (I think of it as a ticketing system, so blur those words)
seph
08/26/2020, 12:43 PM
I think if it’s easier for you to not build it, that’s probably fine? Like, this is iterative. Better to get a simple thing in, and build on it
seph
08/26/2020, 12:44 PM
If you can, please drop the tickets into https://github.com/osquery/osquery/milestone/50 or do something so we can find them and work with them en-mass
b
Benjamin Herrenschmidt
08/26/2020, 10:03 PMOk, will do later today, thanks