Title
#general
roaet

roaet

06/19/2020, 7:31 PM
Hello! I am interested in possibly adding some additional targets for a preexisting feature. I'm not sure which channel is appropriate for that discussion as this would be my first contribution.
zwass

zwass

06/19/2020, 7:32 PM
What is the feature?
roaet

roaet

06/19/2020, 7:33 PM
The startup_items table (windows) (source here: https://github.com/osquery/osquery/blob/3c64d802eb4c2a8de7e9e4ffbf6143e5aa9ef940/osquery/tables/system/windows/startup_items.cpp ) has some registry keys used for lookup. I wanted to add some more registry keys.
7:34 PM
So just adding a line or two to the
std::set<std::string> kStartupRegKeys
variable.
zwass

zwass

06/19/2020, 7:42 PM
Do you expect this to be controversial? Probably best off just putting up a PR.
roaet

roaet

06/19/2020, 7:43 PM
I doubt it will be controversial. I was in process of making the PR. I read contrib but wanted to make sure there weren't any gotchas for new contributors.
zwass

zwass

06/19/2020, 7:45 PM
As long as you can sign the CLA should be little trouble 🙂
roaet

roaet

06/19/2020, 7:51 PM
If I had questions about current existing keys do you know where I should go to ask them (channel-wise)?
zwass

zwass

06/19/2020, 8:40 PM
#windows probably best
roaet

roaet

06/19/2020, 8:40 PM
Thank you!