<@U068RCQBLHL> <@U7QP20JQH> I thought this PR was ...
# core
z
@Micah Sorenson @seph I thought this PR was going to be ready to merge, but when I dug deeper a number of concerns came up (https://github.com/osquery/osquery/pull/8715#pullrequestreview-3565303012). Was planning to cut the release today... do we want to get this hammered out in the next couple days and hold off the release? Or can it wait?
s
I'll ping Micah. My bias would be to wait a couple days, but it would be good to get a release by holidays
ty 1
m
Hello @zwass, I'm taking a look and addressing the concerns you mentioned in the PR. I should have a commit going up in a little bit for these.
I've made a new commit to hopefully address everything properly, so please let me know if there are any other concerns and I'll get on them!