Hey <@UC9UK6BC1>, Will try and get you a review to...
# generalt
thor
09/17/2018, 2:11 PM
Hey @Evgeny Sidorov, Will try and get you a review today!
e
Evgeny Sidorov
09/18/2018, 4:20 PMThanks for the review, I'll make all the changes and get back.
Evgeny Sidorov
09/18/2018, 4:22 PMThe only thing I'd like to keep is column names like
capnamet
thor
09/18/2018, 4:29 PM
That's fine. Would you mind leaving a note about that on the PR? Also it might help if you add more description information for the column, just so it's known why that was labeled as such perhaps?
e
Evgeny Sidorov
09/18/2018, 9:25 PMSure, I'll add a comment on that and add some links to linux kernel sources. I'm planning to fix all the issues by Monday
👍 1
Evgeny Sidorov
10/01/2018, 6:23 PMI'm sorry I have a business trip, I'm working on the fixes, but they'll be ready in probably two weeks. Could you please take a look at my comments in the PR?
👍 1
Evgeny Sidorov
10/16/2018, 10:59 AMHello, I pushed a new bunch of changes and fixes according to the review comments. Could you please take a look? It also seems to be an issue with CI as code audit and freebsd build are still in pending state.
t
thor
10/16/2018, 7:44 PM
Sure, we'll take a look, unfortunately we're still in Lockdown right now, so it might be a while longer before things happen 😞
👍 1
e
Evgeny Sidorov
10/21/2018, 5:03 PMCan you tell a few words about the overall development process? I'm trying to find out what time is the best to submit PRs
t
thor
10/22/2018, 3:35 PM
Ah, yeah sorry, this is just unfortunate timing really. Typically we try to stay on top of PRs, but considering the repo is on lock down temporarily we're not spending much time on reviews, as we're not currently accepting PRs, but will be again hopefully soon. @fmanco might have a better idea what the timeline looks like for when PRs will start landing again, sorry about that!
f
fmanco
10/23/2018, 2:35 PMHey @Evgeny Sidorov the current plan is to start accepting PRs again after the 19th of November. You can read the announcement at https://osquery.io/blog/osquery-lockdown.
👍 2
4 Views