https://github.com/osquery/osquery logo
#core
Title
# core
t

theopolis

06/14/2021, 3:53 AM
I think I'd like to test 7158 in a few more circumstances just to be extremely sure of the logic. I tried to refactor it a little to write tests but there are many moving parts to it. Cvents+sql+registry make it difficult to untangle into a unit test.
j

Juan Alvarez

06/14/2021, 9:52 AM
If i can help doing any specific tests let me know. I am happy to do so as i am still running tests for #7112
t

theopolis

06/14/2021, 1:37 PM
thanks! My preference is still to wait, I think we should rethink the approach in that PR and avoid setting the denylist flag for those queries in the first place. This way, if other parts of the code want to inspect the denylist they do not have to implement the same exception logic.
👍 1
3 Views