Hum the Dockerfile is something more connected to the CI and the osquery repo than the toolchain. The CMake version in there might have to be updated, we might need to update the OS and also the list of packages (python stuff) for tests.
I don’t think that the change rate of that file is in sync with the toolchain. The toolchain repo was really meant for the compiler only, and all the files there are meant to produce a release tar.gz.
03/18/2021, 12:40 AM
Yes. If we merge that I'll pr the removal.
It's also not osquery code. It's just kinda support crap.
But I don't feel super strongly. I just want it done. Happy to move the PR to the other repo.
03/18/2021, 12:42 AM
I have a slight bias towards having it in the osquery repo as we might want to change the toolchain around, make an official new release, then finally update the pinned release in the osquery dockerfile and publish that change distinctly.
I know the dockerfile in the osquery repo isn’t strictly what is on docker registry but I like to think that it’s the “source” representation.
03/18/2021, 12:45 AM
Okay. That's two votes to leave it in osquery. I'll defer on this. I'll move it after child bedtime. Please also review for content.