Title
#core
s

seph

02/16/2021, 7:18 PM
I clicked some things around what actions are required. And https://github.com/osquery/osquery/pull/6953 should remove Azure.
Stefano Bonicatti

Stefano Bonicatti

02/17/2021, 7:21 PM
I'm not sure where these come from specifically but it seems that they'll never become "ready"
7:22 PM
I would say that the required checks on all the specific workflow instances are enough
s

seph

02/17/2021, 7:39 PM
Those might have been azure ones. I don’t know if I clicked all the right things
7:41 PM
They might also be older github actions
Stefano Bonicatti

Stefano Bonicatti

02/17/2021, 7:41 PM
yeah I mean, they match the names of the workflows on github actions, but they don't seem to be used
s

seph

02/17/2021, 7:42 PM
I have unchecked them as required
7:42 PM
This might mean we’re tracking something off in the workflows. But we can learn and iterate
7:43 PM
From a UX perspective, it feels like we’re missing something. Like we should be able to require the workflow to pass, and not enumerate the sub-OSes in the workflow. So I think we’re probably missing something
Stefano Bonicatti

Stefano Bonicatti

02/17/2021, 7:44 PM
I think this was noticed by Alessandro too initially when adding the support. There were no checks for the whole thing
7:44 PM
while for instance Azure provides a check for the entire pipeline
s

seph

02/17/2021, 7:44 PM
Yeah, I remember that about your Azure setup. It seemed nice.
7:44 PM
A quick google finds https://github.community/t/status-check-for-a-matrix-jobs/127354/2 which is a way to flag it
Stefano Bonicatti

Stefano Bonicatti

02/17/2021, 7:46 PM
Right, it needs to be created manually. Sorry I actually remember talking about this too now. Good catch though.
s

seph

02/17/2021, 7:47 PM
I don’y think it’s a blocker. I think it’s mostly a nice to have to correctly manage the required checks on a branch
7:47 PM
Anyhow, I removed the one that weren’t happening.
Stefano Bonicatti

Stefano Bonicatti

02/17/2021, 7:47 PM
It is still partially annoying because we have multiple jobs and we need to list them in this final job we use for the check, while on Azure it was automatic.. you couldn't forget to add one.
s

seph

02/17/2021, 7:48 PM
Maybe. There might be a way to create a single one that farms it out. But I think we’re also just shuffling it around.
7:48 PM
Either we have a single job that depends on the matrix jobs. Or we have a success job per matrix.
Stefano Bonicatti

Stefano Bonicatti

02/17/2021, 7:49 PM
yeah but in every case you need to change the build.yml file to make it work. Just saying that's different, beyond that, we will live! ahah
s

seph

02/17/2021, 7:49 PM
I don’t think we do
7:50 PM
the link above had some suggestions for how to depend on the entire matrix
Stefano Bonicatti

Stefano Bonicatti

02/17/2021, 7:50 PM
There are multiple matrix
7:50 PM
one for each platform
7:50 PM
and also jobs that are outside the matrix logic
s

seph

02/17/2021, 7:50 PM
Right. We need a job per matrix, one a job that enumerates all matrixes.
7:50 PM
While we might change what’s in the matrixes, I don’t think we add new platforms very often
Stefano Bonicatti

Stefano Bonicatti

02/17/2021, 7:51 PM
Well there are also jobs which are "standalone", like the check source code one
s

seph

02/17/2021, 7:52 PM
Sure. But we’re still talking 4 — lint, plus the 3 platforms
Stefano Bonicatti

Stefano Bonicatti

02/17/2021, 7:54 PM
Just to clarify I'm not saying that it's a major issue, just saying that it's not as automatic as it was on Azure which was automatically adding whatever job was created under the single "osquery" pipeline check. We definitely have ways to make it work in GA just saying that if you have to change the build.yml to add a new standalone job, you've got to remember to add that to the final check job too, unless there's a way to list all the jobs into the
needs
key, programmatically.
s

seph

02/17/2021, 7:54 PM
Oh, I see… in Azure you could do a single “everything passes”
7:54 PM
Yeah, perhaps not as clean
Stefano Bonicatti

Stefano Bonicatti

02/17/2021, 7:55 PM
yeah sorry if I made it seem bigger than it was ^^'
s

seph

02/17/2021, 7:56 PM
As an aside, it’s kinda weird comparing Azure to github. Given that the latter is built on the former, I’d expect more convergence. But they’re oddly different
Stefano Bonicatti

Stefano Bonicatti

02/17/2021, 7:56 PM
yep ahah. Probably different UX/UI teams
7:57 PM
(just random guessing, it's not necessary obv.)