Title
#core
Stefano Bonicatti

Stefano Bonicatti

12/23/2020, 4:17 PM
Well that's the giveaway, because you see
[...]  
    MSVCP140.dll
    VCRUNTIME140.dll
    api-ms-win-crt-runtime-l1-1-0.dll
    api-ms-win-crt-heap-l1-1-0.dll
    api-ms-win-crt-stdio-l1-1-0.dll
    api-ms-win-crt-string-l1-1-0.dll
    api-ms-win-crt-convert-l1-1-0.dll
    api-ms-win-crt-utility-l1-1-0.dll
    api-ms-win-crt-filesystem-l1-1-0.dll
    api-ms-win-crt-time-l1-1-0.dll
    api-ms-win-crt-math-l1-1-0.dll
    api-ms-win-crt-locale-l1-1-0.dll
    api-ms-win-crt-environment-l1-1-0.dll
thor

thor

12/23/2020, 9:59 PM
Ah ok, I understand now, so the latest binary that I just built on my host has the following for dependents, note the missing CRT dlls, so I think we're good with this right?
PS C:\Users\Nicholas\work\repos\osquery\build\windows10> dumpbin.exe /dependents .\osquery\Release\osqueryd.exe                                                                Microsoft (R) COFF/PE Dumper Version 14.16.27032.1
Copyright (C) Microsoft Corporation.  All rights reserved.


Dump of file .\osquery\Release\osqueryd.exe

File Type: EXECUTABLE IMAGE

  Image has the following dependencies:

    RPCRT4.dll
    SHLWAPI.dll
    dbghelp.dll
    KERNEL32.dll
    USER32.dll
    SHELL32.dll
    ole32.dll
    OLEAUT32.dll
    ADVAPI32.dll
    ntdll.dll
    WS2_32.dll
    IPHLPAPI.DLL
    NETAPI32.dll
    VERSION.dll
    WTSAPI32.dll
    Secur32.dll
    dbgeng.dll
    bcrypt.dll
    CRYPT32.dll
    WINTRUST.dll
    SETUPAPI.dll
    USERENV.dll
    wevtapi.dll

  Summary

      108000 .data
       92000 .pdata
      542000 .rdata
       23000 .reloc
        1000 .rsrc
      DA7000 .text
9:59 PM
Is there anything else I should be checking before I produce a signed build for 4.6.0.2?
Stefano Bonicatti

Stefano Bonicatti

12/23/2020, 10:13 PM
Seems correct. I don't think there's anything else (avx instructions is a bit tricky right now to test and I don't believe something has changed from other builds)
thor

thor

12/23/2020, 10:15 PM
Yeah ok, sounds good
10:15 PM
I'm running the build now, will have some signed packages hopefully soon but if it doesn't finish before my daughters nap ends it'll be tonight 😅
s

seph

12/26/2020, 6:20 PM
Is this the kind of check we can bake into CI?
6:20 PM
Oh, I see you asked that as well