I’m building my PR for copyright changes. using `m...
# core
s
I’m building my PR for copyright changes. using
make -j7
and I’m encountering a handful of build errors. Re-building fixes them, and I think these are probably fallout from the include reorg. In thread
Copy code
[ 28%] Building CXX object libs/src/rocksdb/CMakeFiles/thirdparty_rocksdb.dir/src/env/io_posix.cc.o
[ 28%] Linking CXX static library libthirdparty_rocksdb.a
[ 28%] Built target thirdparty_rocksdb
make: *** [all] Error 2
Copy code
[  9%] Building C object libs/src/lzma/CMakeFiles/thirdparty_lzma.dir/src/src/liblzma/common/filter_flags_decoder.c.o
[  9%] Building CXX object libs/src/boost/CMakeFiles/thirdparty_boost_filesystem.dir/src/libs/filesystem/src/codecvt_error_category.cpp.o
In file included from /tmp/osquery/libraries/cmake/source/boost/src/libs/serialization/src/basic_text_iprimitive.cpp:20:
In file included from /tmp/osquery/libraries/cmake/source/boost/src/libs/serialization/include/boost/archive/impl/basic_text_iprimitive.ipp:25:
/tmp/osquery/libraries/cmake/source/boost/src/libs/serialization/include/boost/archive/iterators/remove_whitespace.hpp:21:10: fatal error: 'boost/iterator/iterator_adaptor.hpp' file not found
#include <boost/iterator/iterator_adaptor.hpp>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Copy code
[ 13%] Linking C static library libthirdparty_libxml2.a
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: libthirdparty_libxml2.a(xzlib.c.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: libthirdparty_libxml2.a(xzlib.c.o) has no symbols
[ 13%] Built target thirdparty_libxml2
make: *** [all] Error 2
make -j4
did not have any issues.
cc @theopolis
t
good find
s
I assume you’ll either PR or ticket it. Though if you want me to make a ticket, I can dump this into one
t
Yes please, can you create a GitHub issue? It might take some time to root cause.