Title
#core
Mike Myers

Mike Myers

06/01/2020, 5:15 PM
What's everyone's feeling on setting a date for https://github.com/osquery/osquery/milestone/49 ?
5:19 PM
Because we have a CVE, I think there's good reason to make movement on the release. Let me know if Stefano's time is needed, I can try to bring him back for that
4:15 PM
I know everyone is busy right now, but can we set a goal date for the release process? Whose time is needed?
Stefano Bonicatti

Stefano Bonicatti

06/03/2020, 5:14 PM
I can help with the process this Friday, starting from writing the changelog and prepare some test builds. What do you all think? Would be cool to have https://github.com/osquery/osquery/pull/6414 and https://github.com/osquery/osquery/pull/6413 in that, so I'll address the review there first, then I can start on the release process.
s

seph

06/03/2020, 8:03 PM
TBH I think this is mostly waiting on #6413 and #6414, which are both approved and in Stefano’s court to merge. I think the other two things things aren’t going to happen fast enough
Stefano Bonicatti

Stefano Bonicatti

06/03/2020, 8:06 PM
@seph If by "not going to happen fast enough", you mean the release process, Friday, I agree, but the question was more "is everyone ok if we start to prepare it?". We have to start somewhere 😄
s

seph

06/03/2020, 8:07 PM
Er, I mean https://github.com/osquery/osquery/pull/5901 and https://github.com/osquery/osquery/issues/6411 are probably not going to merge fast enough to be part of 4.4.0 and should be pushed to the next release
Stefano Bonicatti

Stefano Bonicatti

06/03/2020, 8:08 PM
aaah sorry milestone!
s

seph

06/03/2020, 8:08 PM
I’ve moved those to 4.5.0 for clarity. I’m good with us cutting pre-release builds as soon as your container PRs merge
theopolis

theopolis

06/03/2020, 10:59 PM
I have a doc fix I can PR tonight
s

seph

06/04/2020, 12:04 AM
Whatever is merged, is awesome 🙂 Stick it in the milestone if you want to make sure we hold for it
Mike Myers

Mike Myers

06/05/2020, 5:38 PM
We have @Stefano Bonicatti available today to help with the milestone, but one thing that came up is that we really want Alessandro's Windows event publisher PR merged so I added it to the milestone, and we think that's not going to delay (already reviewed, just needs some nitpick fixes to get approval)
s

seph

06/05/2020, 5:40 PM
I’m :thumbsup_all: waiting if you want to get #6280 in. And, TBH anything else you have that’s basically ready to go.
Stefano Bonicatti

Stefano Bonicatti

06/05/2020, 5:41 PM
To add to that, I'm not going to tag today, but I will start the process, at least writing the changelog and preparing clean VMs to do builds, which takes a while. But ideally Monday or Tuesday would be nice to have the tag, changelog and packages ready 🙂
s

seph

06/05/2020, 5:47 PM
I can probably help with changelogs as well
Stefano Bonicatti

Stefano Bonicatti

06/05/2020, 6:19 PM
ok, I'm going to merge the two PRs now since they will effectively have the same change to be done, so I'll just open it on a new PR. As for the changelog, do you want to split it in half? (As in half the merged PRS)
6:19 PM
And each work on one? @seph?
s

seph

06/05/2020, 6:20 PM
Not sure? It doesn’t feel like it splits easily One of us should take a pass. Want me to start?
Stefano Bonicatti

Stefano Bonicatti

06/05/2020, 6:21 PM
If you want, definitely 😄 I can prepare my VMs then
s

seph

06/05/2020, 6:21 PM
I’ll try to start. sure.
theopolis

theopolis

06/05/2020, 10:16 PM
Ok I will try to sneak in a PR or two tonight then. I promise small fixes 😃
1:41 AM
I just reviewed the Windows Event publisher PR. I requested some changes and I am available most of the weekend to iterate.
2:33 AM
I submitted all the PRs I had planned. If you folks are around this weekend TTYL
Mike Myers

Mike Myers

06/08/2020, 4:38 PM
@Stefano Bonicatti @alessandrogario is it possible to get this PR feedback addressed in time for 4.4.0?