as long as we’re asking for merges, can I get an o...
# corec
Chris Broome
04/09/2020, 4:28 PMas long as we’re asking for merges, can I get an official review on https://github.com/osquery/osquery/pull/6352? Not sure why the linux builds aren’t working either 🤷♂️
s
Stefano Bonicatti
04/09/2020, 4:49 PMThere have been an error downloading the ccache cache, the build has been restarted
s
seph
04/09/2020, 4:52 PM
I love the PR. I’m under the impression we need some discussion about whether to include the statement, and I don’t know if that’s going to resolve before we want to cut 4.3.0
c
Chris Broome
04/09/2020, 4:56 PMThanks for the feedback! I actually find the statement to be pretty useful.
s
seph
04/09/2020, 4:57 PM
I saw 🙂 TBH I’m agnostic here, but it was raised as a question in office hours, so I’d rather see it discussed and decided before merge.
c
Chris Broome
04/09/2020, 4:57 PMyep makes sense
s
seph
04/09/2020, 4:58 PM
And since we;re cutting 4.3.0 todayish, it seems unlikely to get in 😞
seph
04/09/2020, 4:58 PM
OTOH, they’ll be another release. There always is 🙂
c
Chris Broome
04/09/2020, 4:58 PMunderstood
Chris Broome
04/09/2020, 4:58 PMindeed!
s
seph
04/09/2020, 4:58 PM
But yeah, I think it’s a great addition
➕ 1
5 Views