Alright, #6170 shipped. <@U6EFFT5FG> if you get a ...
# coret
thor
02/03/2020, 3:51 PM
Alright, #6170 shipped. @alessandrogario if you get a chance can you rebase #6197 and see if it passes tests? I'll see if I can rebase #6044 somehow without ted.
a
alessandrogario
02/03/2020, 3:56 PM
Done rebasing! will keep an eye on the tests
😍 1
t
thor
02/03/2020, 4:06 PM
Do you think it's worth having an explicit test case for this? Maybe I can check if removing your code causes tests to fail? That'd be super hot 🙂
a
alessandrogario
02/03/2020, 4:07 PM
If there is any test catching that, we'll see the error now on master
t
thor
02/03/2020, 4:07 PM
OH shit, that's right!
thor
02/03/2020, 4:07 PM
I rebased 6044 so we should also see it there.
a
alessandrogario
02/03/2020, 4:08 PM
Teddy's PR was fixing a couple of things to make initialization more structured
alessandrogario
02/03/2020, 4:08 PM
I should rebase on his PR before we merge
6 Views