So back to adding a 3rd party lib.
I created the f...
# corep
packetzero
11/07/2019, 6:54 PMSo back to adding a 3rd party lib.
I created the following files :
libraries/cmake/source/conveyor/CMakeLists.txt
libraries/cmake/source/modules/Findconveyor.cmake
third-party/conveyor/osquery.library
third-party/conveyor/BUCK
Added new submodule:
libraries/cmake/source/conveyor/src
Updated /CMakeLists.txt:
+"Linux,Darwin,Windows:conveyor"
packetzero
11/07/2019, 6:54 PMYet, I still get the following cmake error:
CMake Error at CMakeLists.txt:148 (find_package):
By not providing "Findconveyor.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "conveyor",
but CMake did not find one.
Could not find a package configuration file provided by "conveyor" with any
of the following names:
conveyorConfig.cmake
conveyor-config.cmake
s
Stefano Bonicatti
11/07/2019, 7:12 PMthat's really strange.. I just tried just to add the Findconveyor.cmake file and the "Linux,Darwin,Windows:conveyor", and works here.
Though I have a suspicion. Could you try to run from the build dir (I'm assuming you're on Linux)
cmake -LAH <source_dir> | grep CMAKE_MODULE_PATHp
packetzero
11/07/2019, 7:26 PMi'm on MacOS
s
Stefano Bonicatti
11/07/2019, 7:28 PMah I see, should be the same 🙂
Stefano Bonicatti
11/07/2019, 7:28 PMat the same time, have you tried deleting the
CMakeCache.txtp
packetzero
11/07/2019, 7:29 PMCMAKE_MODULE_PATH:STRING=/Users/me/osq/osquery/cmake/modules;/Users/me/osq/osquery/libraries/cmake/source_migration/modules;/Users/me/osq/osquery/libraries/cmake/facebook/modules;/Users/me/osq/osquery/libraries/cmake/source_migration/modules;/Users/me/osq/osquery/libraries/cmake/facebook/modules;/Users/me/osq/osquery/libraries/cmake/source_migration/modules;/Users/me/osq/osquery/libraries/cmake/facebook/modules
s
Stefano Bonicatti
11/07/2019, 7:29 PMI've just found a bug where some paths to the modules folder gets added each time one configures with CMake.. so I wonder if you hit some limit there and everything goes haywire from there.
p
packetzero
11/07/2019, 7:29 PMyeah, I usually delete cache file before I run cmake.
s
Stefano Bonicatti
11/07/2019, 7:30 PMhum ok, so those paths seems fine right?
Stefano Bonicatti
11/07/2019, 7:30 PMmeaning, at first look they seem but, are they correctly pointing to an existing path? (the ones in CMAKE_MODULE_PATH)
p
packetzero
11/07/2019, 7:31 PMyes they do
packetzero
11/07/2019, 7:34 PMthis is a good version, right? cmake version 3.15.4
s
Stefano Bonicatti
11/07/2019, 7:34 PMoh wait, I got it now. You have to use source_migration, because for macOS we are only getting some library from source
Stefano Bonicatti
11/07/2019, 7:35 PMyou need to use the other path, not
sourcesource_migrationp
packetzero
11/07/2019, 7:35 PMah... will try that.
packetzero
11/07/2019, 7:35 PMthx
s
Stefano Bonicatti
11/07/2019, 7:36 PMThough if that's a library that goes on all platform, then I would leave it in
sourceFind<library>.cmakesourcep
packetzero
11/07/2019, 7:36 PMAnd that is case whether I use a submodule or download a tgz ?
s
Stefano Bonicatti
11/07/2019, 7:37 PMYes, but what you do then in the Find<library>.cmake is different, specifically in how you provide the targets
Stefano Bonicatti
11/07/2019, 7:39 PMor actually no, scratch that, this is still the source layer, sorry I was thinking to binary releases
p
packetzero
11/07/2019, 7:40 PMokay, so I am adding a file
libraries/cmake/source_migration/modules/Findconveyor.cmakes
Stefano Bonicatti
11/07/2019, 7:40 PMyeah, which should just include the other Find under source
Stefano Bonicatti
11/07/2019, 7:40 PMas we are doing for the other libraries which we have "migrated"
p
packetzero
11/07/2019, 7:47 PMthanks @Stefano Bonicatti That got me past it.
s
Stefano Bonicatti
11/07/2019, 7:49 PMYou're welcome!