Title
#core
s

seph

10/05/2019, 3:40 AM
For this git submodule info, I dumped a bunch of info into https://github.com/osquery/osquery/issues/5862 The failure cases I have, are all in git 2.7. (cc: @alessandrogario @theopolis)
theopolis

theopolis

10/05/2019, 2:54 PM
Thanks for this investigation. The cheat-codes for making
git
verbose are very helpful. Potential bad news is that I recall trying a newer
git
(2.23?) and seeing a failure.
s

seph

10/05/2019, 2:56 PM
Interesting. I’d certainly believe it happens.
2:56 PM
It all feels a bit fragile.
theopolis

theopolis

10/05/2019, 2:57 PM
CMake might need a
-DOSQUERY_LIBRARIES_FULL_CLONE
option
s

seph

10/05/2019, 2:58 PM
Maybe. But if it’s just a couple, we can make them non-shallow. Or see if a more recent git ref alleviates it.
2:58 PM
We might also get better behavior from github, if we can refer to a tag, not a ref. But that feels less controlled.
2:59 PM
All goes back to needing a reproduce case ¯_(ツ)_/¯
Stefano Bonicatti

Stefano Bonicatti

10/05/2019, 3:50 PM
Also, Linux with 2.23.0 fails
3:50 PM
2.19.1 is fine