Title
#core
theopolis

theopolis

08/29/2019, 12:14 PM
if anyone has time for a code review today, can you look at https://github.com/osquery/osquery/pull/5732/files this seems like a half-measure but it does seem to work.
s

seph

08/29/2019, 12:32 PM
i'm not at a real computer, and can't check the sqlite docs. i agree this looks kinda janky, but is probably fine. the sqlite thing i want to check is about how virtual tables are invoked. i think there's a create vs call convention. we don't use that, and i wonder if the source of this bug is the lack of utilization of the create routine.
theopolis

theopolis

08/29/2019, 2:01 PM
I also think the use of the static variable indicating 'first config' can be replaced with a check if the view exists or not.
2:03 PM
I'll merge for now and then we can address a follow up in the open issue.
s

seph

08/29/2019, 2:05 PM
yeah, i agree there's probably a cleaner if-view-exists. getting something into CI would let us refactor that
Stefano Bonicatti

Stefano Bonicatti

08/30/2019, 9:30 AM
I don't know if this is related or not but I've also recently discovered this https://github.com/osquery/osquery/issues/5714
9:31 AM
I still don't have the full awareness of what the implications are