Channels
android_tests
apple-silicon
arm-architecture
auditing-warroom
aws
carving
code-review
community-feeds
core
darkbytes
doorman
ebpf
eclecticiq-polylogyx-extension
extensions
file-carving
fim
fleet
fleet-dev
fleetosquery
foundation
fuzzing
general
golang
goquery
infrastructure
jobs
kolide
linen-dev
linux
macos
officehours
osctrl
plugins
process-auditing
querycon
queryhub
random
selfgroup
sql
tls
uptycs
vendor-feeds
website
windows
zeek
zentral
zercurity
Title
a
Andrea
06/07/2022, 10:32 AMHi everyone, quick question: I was wondering what exactly "no state" means 🤔 this is with the fix for users/groups table so 5.3.0 All tests for users and groups are failing like this.
[ RUN ] UserGroups.test_sanity
E20220607 10:13:31.404719 9192 virtual_table.cpp:1006] Exception while executing table user_groups: no state
C:\workspace\senseon-enterprise-endpoint\tests\integration\tables\helper.cpp(160): error: Value of: status.ok()
Actual: false
Expected: true
Query execution failed with error: "no state"
C:\workspace\senseon-enterprise-endpoint\tests\integration\tables\user_groups.cpp(62): error: Expected: (data.size()) > (0ul), actual: 0 vs 0
[ FAILED ] UserGroups.test_sanity (1 ms)s
Stefano Bonicatti
06/07/2022, 10:51 AMHello Andrea! Does osqueryi works when trying to query the users or groups table, or it fails there too?
also, how the tests were run? what was the command line?
oh I see the tests throwing exceptions in the CI, but not failing, because we catch the exceptions and transform them in an empty response.
One issue I see (and hopefully the only one), is that I forgot to do the dance of starting up the needed services for some of the tests that query tables that internally use the users or groups cache
Although it’s strange that it’s actually failing for you on the test suite which actually initializes the needed services.
a
Andrea
06/07/2022, 12:55 PMTBF is not osquery vanilla that's why I asked only what could "no state" mean.
s
Stefano Bonicatti
06/07/2022, 12:57 PMI see; it’s an exception thrown by accessing a
std::futurestd::promisea
Andrea
06/07/2022, 12:57 PMctest --output-on-failure --config RelWithDebInfo*-C RelWithDebInfoBTW I am quite sure this is not what you wanted https://github.com/osquery/osquery/blob/43afb3c1fc9ef6a50b8b3093c92b60eb5bb46524/osquery/tables/system/windows/users.cpp#L70
s
Stefano Bonicatti
06/07/2022, 1:38 PM🤦
yeah that was me testing that exceptions would go through with the change on the other PR
a
Andrea
06/07/2022, 1:46 PMyeah no worries, it happens.
s
Stefano Bonicatti
06/07/2022, 1:47 PMAnyway, thanks for catching these issues!
a
Andrea
06/07/2022, 1:48 PM✌️
unfortunately no joy for me.. I still see the std::future_error exception being thrown 🤔 is
s
Stefano Bonicatti
06/07/2022, 3:19 PMDoes the official build of the tests behaves the same?
a
Andrea
06/07/2022, 3:19 PMI haven't tried to build from scratch but it looks like I am going to..
I wonder if I am missing some global initialisation..
s
Stefano Bonicatti
06/07/2022, 3:25 PMWhat has been fixed by PR 7620 is indeed some missing initialization for some of the tests that were using the users or groups cache indirectly. The initialization is done in the test itself.
I’m not sure what the code you’re compiling looks like, that’s why I was wondering if it happened the same with the upstream source code.
a
Andrea
06/07/2022, 3:30 PMyeah that s what I thought
FYI on the osquery branch 5.3.0 the tests are working fine.
Just an heads up.. it looks like the static method to initialise the Test Suite it is called
SetUpTestCaseor possibly we are using different version of google test 🤔 didn't get a compiler error though
s
Stefano Bonicatti
06/11/2022, 5:28 PMa
Andrea
06/11/2022, 7:40 PMah yeah that makes sense