Anyone have thumbs for some prior office hours?
* ...
# foundations
seph
01/15/2020, 3:48 PM
Anyone have thumbs for some prior office hours?
* https://github.com/osquery/foundation/pull/42
* https://github.com/osquery/foundation/pull/43
t
theopolis
01/15/2020, 7:54 PM
I can put this on my TODO but I have been swamped with work this week :/
s
seph
01/15/2020, 7:54 PM
There’s no real urgency here. They’re just lingering.
seph
01/15/2020, 7:55 PM
Ultimately, its office hours. Eventually I’ll just remove the code review restrictions 🙂
t
theopolis
01/15/2020, 8:18 PM
Approved!
theopolis
01/15/2020, 8:24 PM
@seph I cannot edit the file here: https://github.com/osquery/foundation/pull/46/files but it looks like there is a copy-paste error at the bottom, lots of new lines and then repeated content
s
seph
01/15/2020, 8:24 PM
Nice catch. Removed the extra paste.
👍 1
seph
01/15/2020, 8:25 PM
Ther last hours you might have comments on. There was stuff related to work you did that I didn’t dig up links to
t
theopolis
01/15/2020, 8:25 PM
I read though the minutes and it seems accurate
s
seph
01/15/2020, 8:26 PM
I’m happy enough. I lost time to dig up the links to the buck include work you were doing
2 Views