Title
#foundation
theopolis

theopolis

09/06/2019, 6:34 PM
also, I did not like the way the build badges looked on the Readme so I removed them: https://github.com/osquery/osquery/blob/427914bde0a0b228bdfd16c15eeaa86d379d5334/README.md thoughts?
s

seph

09/06/2019, 6:46 PM
i think that's wise -- i don't think it makes sense to keep them, they're ci noise.
6:46 PM
i'm mobile, can't do a real review though
6:52 PM
reviewed enough. LGTM
a

alessandrogario

09/06/2019, 6:55 PM
what about adding them as a single row at the bottom? just thinking
s

seph

09/06/2019, 6:56 PM
they're required to be green to merge. so presenting them feels like visual noise.
a

alessandrogario

09/06/2019, 6:56 PM
they do convey information: whether CI is being maintained and which platforms are being tested
6:57 PM
the reason osql was born was because the CI indicators were all red
s

seph

09/06/2019, 6:57 PM
i'd be down for thinking about how to present the tester platforms.
theopolis

theopolis

09/06/2019, 6:57 PM
maybe if we use the aggregate status
a

alessandrogario

09/06/2019, 6:58 PM
yeah, even a single indicator is fine imho
s

seph

09/06/2019, 6:58 PM
aggregate status doesn't show the depth of platforms. maybe a different page with all the platform / ci links?
theopolis

theopolis

09/06/2019, 6:58 PM
if you click into the badge it shows all the jobs
a

alessandrogario

09/06/2019, 6:59 PM
if you click on it though it will show which platforms are tested
s

seph

09/06/2019, 6:59 PM
aggregate might be good enough then. and a single ci link is fine for that info list
s

seph

09/06/2019, 7:01 PM
i'm sold. (i'm easy here)