https://github.com/osquery/osquery logo
Join Slack
Powered by
also, I did not like the way the build badges look...
# foundation
t
also, I did not like the way the build badges looked on the Readme so I removed them: https://github.com/osquery/osquery/blob/427914bde0a0b228bdfd16c15eeaa86d379d5334/README.md thoughts?
s
i think that's wise -- i don't think it makes sense to keep them, they're ci noise.
i'm mobile, can't do a real review though
reviewed enough. LGTM
✔️ 1
a
what about adding them as a single row at the bottom? just thinking
s
they're required to be green to merge. so presenting them feels like visual noise.
a
they do convey information: whether CI is being maintained and which platforms are being tested
☝️ 1
the reason osql was born was because the CI indicators were all red
t
s
i'd be down for thinking about how to present the tester platforms.
t
maybe if we use the aggregate status
a
yeah, even a single indicator is fine imho
s
aggregate status doesn't show the depth of platforms. maybe a different page with all the platform / ci links?
t
if you click into the badge it shows all the jobs
a
if you click on it though it will show which platforms are tested
s
aggregate might be good enough then. and a single ci link is fine for that info list
👍 1
t
s
i'm sold. (i'm easy here)
t
9 Views
Open in Slack
PreviousNext
Powered by