Channels
android_tests
apple-silicon
arm-architecture
auditing-warroom
aws
carving
code-review
community-feeds
core
darkbytes
doorman
ebpf
eclecticiq-polylogyx-extension
extensions
file-carving
fim
fleet
fleet-dev
fleetosquery
foundation
fuzzing
general
golang
goquery
infrastructure
jobs
kolide
linen-dev
linux
macos
officehours
osctrl
plugins
process-auditing
querycon
queryhub
random
selfgroup
sql
tls
uptycs
vendor-feeds
website
windows
zeek
zentral
zercurity
Powered by
Title
m
Mike Myers
07/19/2019, 5:19 PM
folks reviewing PRs, please remember to ask for tests. It's in the PR template, but people aren't always including tests with their code changes.
https://github.com/osquery/osquery/blob/master/.github/PULL_REQUEST_TEMPLATE.md
👍 1
t
theopolis
07/19/2019, 10:55 PM
Also note that many changes are difficult to unit test. At the very least we should ask for a Test Plan so that others can reproduce the testing either during the review or at a later time.
👍 1
3 Views
#foundation
Join Slack