Title
#foundation
Mike Myers

Mike Myers

07/19/2019, 5:19 PM
folks reviewing PRs, please remember to ask for tests. It's in the PR template, but people aren't always including tests with their code changes. https://github.com/osquery/osquery/blob/master/.github/PULL_REQUEST_TEMPLATE.md
theopolis

theopolis

07/19/2019, 10:55 PM
Also note that many changes are difficult to unit test. At the very least we should ask for a Test Plan so that others can reproduce the testing either during the review or at a later time.