Channels
doorman
zercurity
infrastructure
code-review
queryhub
apple-silicon
carving
goquery
aws
querycon
golang
file-carving
fuzzing
help-proxy
darkbytes
process-auditing
general
windows
random
fleet-dev
tls
fim
awallaby
zentral
zeek
auditing-warroom
linen-dev
fleetosquery
plugins
jobs
arm-architecture
uptycs
android_tests
selfgroup
vendor-feeds
fleet
eclecticiq-polylogyx-extension
ebpf
website
core
macos
kolide
osctrl
extensions
foundation
sql
officehours
linux
community-feeds
Powered by
#foundation
Title
# foundation
m
Mike Myers
07/19/2019, 5:19 PM
folks reviewing PRs, please remember to ask for tests. It's in the PR template, but people aren't always including tests with their code changes.
https://github.com/osquery/osquery/blob/master/.github/PULL_REQUEST_TEMPLATE.md
👍 1
t
theopolis
07/19/2019, 10:55 PM
Also note that many changes are difficult to unit test. At the very least we should ask for a Test Plan so that others can reproduce the testing either during the review or at a later time.
👍 1
3 Views
Post