<@U6EFFT5FG> so .. flags.cmake or glbals.cmake ? :...
# arm-architecture
b
@alessandrogario so .. flags.cmake or glbals.cmake ? 🙂
a
yes, it's just a tiny nitpick, I think it looks good
b
No I mean which one ?
which file do you want this definition moved to ?
a
globals.cmake for project wide definitions (TARGET_PROCESSOR)
b
Unless I'm mistaken you commented twice on that same bit of the patch with two different suggestions 🙂
ok, perfect, will do
a
while flags/definitions inside flags.cmake
b
oh that line
Copy code
+  add_compile_definitions(__x86_64__)
I see
so split that big hunk into one that defines TARGET_PROCESSOR into globals. and one that uses the latter to set the compile defines in flags.cmake
right ?