Title
#arm-architecture
b

Benjamin Herrenschmidt

08/31/2020, 8:48 AM
@alessandrogario so .. flags.cmake or glbals.cmake ? 🙂
a

alessandrogario

08/31/2020, 8:49 AM
yes, it's just a tiny nitpick, I think it looks good
b

Benjamin Herrenschmidt

08/31/2020, 8:49 AM
No I mean which one ?
8:49 AM
which file do you want this definition moved to ?
a

alessandrogario

08/31/2020, 8:50 AM
globals.cmake for project wide definitions (TARGET_PROCESSOR)
b

Benjamin Herrenschmidt

08/31/2020, 8:50 AM
Unless I'm mistaken you commented twice on that same bit of the patch with two different suggestions 🙂
8:50 AM
ok, perfect, will do
a

alessandrogario

08/31/2020, 8:50 AM
while flags/definitions inside flags.cmake
b

Benjamin Herrenschmidt

08/31/2020, 8:51 AM
oh that line
+  add_compile_definitions(__x86_64__)
8:51 AM
I see
8:51 AM
so split that big hunk into one that defines TARGET_PROCESSOR into globals. and one that uses the latter to set the compile defines in flags.cmake
8:51 AM
right ?