so flags cmake or glbals cmake slightly s

Question

< alessandrogario> so flags cmake or glbals cmake slightly smiling face

alessandrogario · Answer

yes it s just a tiny nitpick I think it looks good

Benjamin Herrenschmidt · Answer

No I mean which one

Benjamin Herrenschmidt · Answer

which file do you want this definition moved to

alessandrogario · Answer

globals cmake for project wide definitions TARGET PROCESSOR

Benjamin Herrenschmidt · Answer

Unless I m mistaken you commented twice on that same bit of the patch with two different suggestions slightly smiling face

Benjamin Herrenschmidt · Answer

ok perfect will do

alessandrogario · Answer

while flags definitions inside flags cmake

Benjamin Herrenschmidt · Answer

oh that line ```+ add compile definitions x86 64 ```

Benjamin Herrenschmidt · Answer

I see

Benjamin Herrenschmidt · Answer

so split that big hunk into one that defines TARGET PROCESSOR into globals and one that uses the latter to set the compile defines in flags cmake

Benjamin Herrenschmidt · Answer

right