Title
#fleet
n

n8felton

01/28/2022, 2:13 PM
After following along with the Terraform configs at https://github.com/fleetdm/fleet/tree/main/tools/terraform to get a POC stood up, I have a number of minor updates I want to submit as a PR. Things like updating the
rds-aurora
module version, updates to some variables to use var.prefix in more locations, and some general shifting of things around. Would it be best to do 1 PR with multiple commits, or chunk out the changes into a few PRs?
Lucas Rodriguez

Lucas Rodriguez

01/28/2022, 2:20 PM
Hi @n8felton! We really appreciate contributions like this! Separate small PRs are always the best option. But, if it's easier for you one PR also works. You can assign @Benjamin Edwards as reviewer (he's the author of the terraform configs).
2:21 PM
Feel free to share us any feedback here (or alternatively create Github issues).
Benjamin Edwards

Benjamin Edwards

01/28/2022, 2:32 PM
Any contributions are much appreciated @n8felton
zwass

zwass

01/29/2022, 6:06 PM
If they are all clearly related changes in the terraform, I think combining in a single PR is probably fine. We can at least take a look at that and suggest splitting it if it seems like it may not be easy to get merged as-is. Thank you!
n

n8felton

02/01/2022, 7:29 PM
Here is our first PR, focused primarily on variables changes to normalize the use of the prefix in more locations.https://github.com/fleetdm/fleet/pull/3967 cc: @Scott Blake