https://github.com/osquery/osquery logo
#fleet
Title
# fleet
d

Dan Achin

06/10/2021, 9:44 PM
anyone know if we can set feature flags in our config.yaml? It looks like there is a pretty easy conversion from Env variable to config file syntax for most stuff, but the feature flags are prefaced by FLEET_BETA in the variable name and I'm not sure how to convert FLEET_BETA_SOFTWARE_INVENTORY=1 to the config file format. I'd much rather use our existing config file vs setting variables outside of it.
Would love some pointers on this if anyone knows!
a

Avi Norowitz

06/11/2021, 8:44 PM
I don't think so. Looking at the code, this environmental variable looks special to me. Flags should show up here, but this one does not: https://github.com/fleetdm/fleet/blob/543f7144d84661913f0ecd722be192bdcbc98b06/server/config/config.go Instead, it looks like the code uses the environmental variable directly: https://github.com/fleetdm/fleet/blob/cb2682c27317e6301dfdaf5e39cf1c77b38f828a/server/service/service_osquery.go#L874
🙏 1
z

zwass

06/11/2021, 9:28 PM
Avi is correct. This was a bit of a hasty first pass at feature flags and we now have some ideas of how to do it better.
🙏 1
d

Dan Achin

06/14/2021, 5:05 PM
ok, so we have to set it as an environment variable. Thanks!
z

zwass

06/15/2021, 5:48 PM
You got it. I documented our proposed approach moving forward and we'll plan to address this before adding any new flagged features. https://github.com/fleetdm/fleet/issues/1092
👍 1
d

Dan Achin

06/17/2021, 9:08 PM
I saw that git issue come through, thanks for that.
5 Views