https://github.com/osquery/osquery logo
f

farfella

08/25/2020, 12:49 PM
Question: chassis_types in chassis_info table, ok to convert these to the actual strings, e.g, “Laptop” vs 9? Will I break anyone using this column and expecting a number? Looking at blame, this should have always returned 0 before.
s

seph

08/26/2020, 1:48 AM
Are you saying that it's wrong and meaningless now, and asking if it's fine to change it? Or something else? Because if it's wrong now, fixing it doesn't feel like a breaking change....
f

farfella

08/27/2020, 11:28 AM
It was wrong— there was a bug that it always returned 0. ;) My fix is in master.
2 Views