Title
#windows
thor

thor

11/07/2019, 5:50 AM
@samuel here's a
4.1.0
build. Note I haven't thoroughly tested this. It's passing tests locally for me, and the service is coming online, so ymmv. Once we tag this as stable I'll build a formal version to ship to upstream Choco.
theopolis

theopolis

11/07/2019, 4:52 PM
hey @thor, let's hold off on publishing anything 4.1.0 related. There are a few bugs and it's not ready for prime time.
4:53 PM
But it is a good time to collect feedback to track fixes needed for a 4.1.1 release candidate.
thor

thor

11/07/2019, 4:53 PM
Gotcha. Definitely didn’t mean to make it a formal publish, I can delete if you’d like, was just making it available to @samuel who sounded like was having some build/pack issues. Sorry!
theopolis

theopolis

11/07/2019, 4:54 PM
Oh of course, I was reacting to
Once we tag this as stable I'll build a formal version to ship to upstream Choco.
I'm just paranoid 🙂
s

samuel

11/07/2019, 4:54 PM
hahaha
4:55 PM
trying to build this nupkg has had me wanting to throw my computer off the building
theopolis

theopolis

11/07/2019, 4:56 PM
packaging is challenging, it's helped me build empathy for all of the work volunteers do to package up the world and make repos/distributions work smoothly!
thor

thor

11/07/2019, 5:00 PM
Ah gotcha! @theopolis I’ll definitely wait for go ahead from y’all before doing anything 😃
theopolis

theopolis

11/07/2019, 5:00 PM
If the cpack/nupkg stuff can land (and is not too much effort) we can add it to the 4.1.1 milestone
thor

thor

11/07/2019, 8:55 PM
Sure, right now I'm just updating documentation, getting
cpack
to build a
.nupkg
is unknown to me as I still need to scope it
theopolis

theopolis

11/08/2019, 1:38 AM
Cool! Hopefully it is straightforward, I see there’s a NuGet cpack generator, so deep diving into its docs and copying the flow of others in the packaging.cmake file. In practice there have been tiny nuances with each type of package needing a bit of debuting