anyone ever add tables to osquery as described in this https://osquery.readthedocs.io/en/stable/development/creating-tables/

Yes, many people have done so.

ahh ok should I be using

.\tools\make-win64-binaries.bat

to compile my own tables into osquery? I tried that and it doesn't seem to add my table ot osqueryi.exe

Yes I believe if you have followed the steps in the doc that would work.

Blow away build directory and build again. Perhaps you added your spec file after an initial build?

interesting I would think that I could rerun that script again without having to blow away the build folder

You are an optimist. 😀 It should work like that, but I have seen times where I have to start fresh with changes to spec files.

I believe it does work when invoking cmake directly, but I think that script may do some funky stuff.

is there a preferable way to do it on windows?