yossarian
01/08/2019, 8:54 PMtools/build_defs/oss/osquery/cxx.bzl
. does anybody know why we’re capping features at Windows 7?akindyakov
01/09/2019, 11:08 AMyossarian
01/09/2019, 3:55 PM>= _WIN32_WINNT_WIN7
instead? it’s currently impossible to use any non-Windows 7 features thanks to the hard defineakindyakov
01/09/2019, 4:58 PM_WIN32_WINNT
is a minimal version of win32 api, but not the version of os itself. So, I is not gonna be an obstacle to use features from the versions before win32 v7, because of backward compatibility. Except that features was deprecated in win7.yossarian
01/09/2019, 6:17 PM_WIN32_WINNT >= _WIN32_WINNT_WIN7
and then do two builds on the CI: one for _WIN32_WINNT_WIN7
and one for the system default. that would allow individual tables to do feature testing without redefining the macro (which would be ugly, like you said), but would still preserve Win 7 compatibility since it would make any non-guarded features a build failure_WIN32_WINNT
to something higher will expose those structures, but will probably make it impossible to merge my changes (since they won’t be windows 7 compatible)akindyakov
01/09/2019, 7:10 PMyossarian
01/09/2019, 7:13 PMFILE_ID_128
structure and GetFileInformationByHandleEx
function) for a new tableakindyakov
01/09/2019, 7:15 PMyossarian
01/09/2019, 8:40 PMakindyakov
01/14/2019, 9:53 AMyossarian
01/14/2019, 3:07 PMakindyakov
01/14/2019, 5:18 PM