is there a ticket for it?
# officehoursf
farfella
11/12/2020, 5:45 AMis there a ticket for it?
a
alessandrogario
11/12/2020, 10:32 AM
Not a dedicated one AFAIK, but here's the latest comment on the issue: https://github.com/osquery/osquery/issues/6709#issuecomment-723374435
alessandrogario
11/12/2020, 10:32 AM
Seems like the problem here is just how bad the generated cpp code is for Thrift
alessandrogario
11/12/2020, 10:33 AM
There used to be a compile-time definition that we didn't port from the old build system named THRIFT_SQUELCH_CONSOLE_OUTPUT; when present, it will automatically hide errors
alessandrogario
11/12/2020, 10:34 AM
we could try to upgrade Thrift to the latest version, re-generate the code and see if it has been improved
alessandrogario
11/12/2020, 10:36 AM
we were thinking of either adding back THRIFT_SQUELCH_CONSOLE_OUTPUT or keep it as it is but add a new osquery flag (something like --verbose_thrift)
alessandrogario
11/12/2020, 10:36 AM
honestly, given how bad it is I am not sure how useful it is to have a flag to toggle it
alessandrogario
11/12/2020, 10:37 AM
It would be nice to drop it and move to something else, but I can see it won't be that easy
alessandrogario
11/12/2020, 10:38 AM
I briefly looked at fbthrift which seems way more maintained but it has huge dependencies
z
zwass
11/12/2020, 3:28 PM
Apache Thrift is a mess for sure. We found tons of race conditions in the Go libraries.
😞 1
a
alessandrogario
11/12/2020, 3:38 PM
We could take a look and see whether there is an opportunity in the future to migrate to something else, maybe supporting both the old and new communication methods for some time
alessandrogario
11/12/2020, 3:40 PM
I've taken a look at grpc some time ago since it seemed to be really popular, and was really disappointed with the C++ SDK due to its low quality
f
farfella
11/12/2020, 3:50 PMThanks! I’ll take a look maybe this weekend.
farfella
11/24/2020, 12:17 PMSorry-- haven't had a chance to look at this yet. :(
3 Views