Hi All, I've got a PR up that could use some exper...
# code-review
j
Hi All, I've got a PR up that could use some experienced eyes: https://github.com/osquery/osquery/pull/8119 Had a little clunkiness at first w/ the clang formatting as it's my first time putting up an osquery PR, but I think I've got it all resolved now. Thanks in advance!
Looks like I'm in the same boat for 8119 Approved, and just needs someone with write access to merge. Also, I can't edit this field, but whichever author merges for me.
Copy code
Development
Successfully merging this pull request may close these issues.

None yet
This PR will fix issue 6852.
s
You can obtain the same effect by writing in the description message of the PR:
Fixes #6852
j
Oh cool! I had it worded slightly different than that. Just updated my description and it worked. Thanks for the tip!
s
No problem, here would be the list of words that are accepted 🙂 https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
j
Thanks for merging!