Title
#code-review
a

alessandrogario

12/13/2021, 6:26 PM
About the Apple Silicon support: I am available for doing pair code reviews on the CMake, and talk about the READMEs we added for each library (cc @seph && @zwass and anyone else with review access and enough time 🙂)
s

seph

12/13/2021, 6:32 PM
I keep trying and bouncing off of the size. I really wish this had come in in different PRs
a

alessandrogario

12/13/2021, 6:38 PM
I guess we can like split it in half, but we'll have to rebase one of top of the other each time we update the base commit to point at the latest commit on master
s

seph

12/13/2021, 6:39 PM
I had recommended doing each library in their own PR, and then one for osquery. But I think the time for this has passed. I think the cost to change is probably now very high
s

sharvil

12/13/2021, 6:40 PM
I have been reviewing this off and on for past few days
a

alessandrogario

12/13/2021, 6:40 PM
I don't think it would have helped that much since we had to change the history several times while we were working on it
s

sharvil

12/13/2021, 6:40 PM
And just built this locally on m1 macbook, and it works great with cmake 3.22 and xcode 13.1
s

seph

12/13/2021, 6:41 PM
I think it would help, because I could review a couple dependancies, and they could merge. Like this I can't even track what I've reviewed. Everytime it rebases I effectively lose that context.
s

sharvil

12/13/2021, 6:41 PM
I haven’t done a line by line review like I usually do given the size, but I keep building that branch
s

seph

12/13/2021, 6:41 PM
I ran one of the CI builds.
6:41 PM
But I do try to do line by line reviews. Even for some of the giant things
Stefano Bonicatti

Stefano Bonicatti

12/13/2021, 6:42 PM
The problem is that there are dependencies that depends on each other, updating one without regenerating the others might break the build
s

seph

12/13/2021, 6:42 PM
Sure. but I'd like to think there was a balance short of "everything"
s

sharvil

12/13/2021, 6:47 PM
I think the pair/group code could work — I don’t mind giving it a shot
a

alessandrogario

12/13/2021, 6:47 PM
let me know whenever you have time to schedule a meeting 🙂
s

sharvil

12/13/2021, 6:54 PM
Yep sounds good — I think Wednesday/Thursday/Friday would work for me
zwass

zwass

12/13/2021, 6:57 PM
I have very little time I could dedicate to this -- Sharvil has been updating me and it sounds like there is good progress. If there's anything I can be helpful with on a half hour call or something like that please let me know and I'll be happy to join.
s

seph

12/14/2021, 5:01 AM
I've managed to review files! 10%
zwass

zwass

12/14/2021, 5:03 AM
Hero! 🏆