Channels
android_tests
apple-silicon
arm-architecture
auditing-warroom
aws
carving
code-review
community-feeds
core
darkbytes
doorman
ebpf
eclecticiq-polylogyx-extension
extensions
file-carving
fim
fleet
fleet-dev
fleetosquery
foundation
fuzzing
general
golang
goquery
infrastructure
jobs
kolide
linen-dev
linux
macos
officehours
osctrl
plugins
process-auditing
querycon
queryhub
random
selfgroup
sql
tls
uptycs
vendor-feeds
website
windows
zeek
zentral
zercurity
Powered by
Title
p
puffycid
03/23/2021, 1:00 PM
Could someone take a look at my PR at
https://github.com/osquery/osquery/pull/6994
And let me know let me know if there r issues or changes that need to be done Thanks
t
theopolis
03/23/2021, 1:05 PM
I can try tonight :)
❤️ 1
p
puffycid
03/30/2021, 1:37 PM
Would it be possible to have this PR be reviewed for feedback this week?
t
theopolis
03/31/2021, 4:02 PM
sorry I was lagged, just provided a review, mostly some general recommendations
👍 1
p
puffycid
04/09/2021, 1:13 PM
All comments should be addresses Could this PR be reviewed again?
t
theopolis
04/11/2021, 3:15 PM
Just took another pass, looking good, a few more suggestions.
p
puffycid
04/14/2021, 10:17 PM
Could this be looked one last time? All comments should be fixed
5 Views
#code-review
Join Slack