Can someone please give the approval on the upgrad...
# code-reviewz
zwass
04/08/2025, 6:03 PM
Can someone please give the approval on the upgrade of the CI ubuntu runners? https://github.com/osquery/osquery/pull/8592 @Stefano Bonicatti @sharvil as discussed in OH
l
Lucas Rodriguez
04/08/2025, 6:10 PMThis may mean Ubuntu 20.04 is not supported anymore? (It may have runtime issues when running on 20.04 due to different glib, etc.)
s
Stefano Bonicatti
04/08/2025, 6:11 PMIt more means it's harder to test on older platforms (older starting from Ubuntu 20.04), but as far as building/targeting older platforms, that's still available. The build can happen on any version of Linux, what would need to change is the toolchain.
Stefano Bonicatti
04/08/2025, 6:12 PMThe toolchain still targets CentOS 6 technically, although some of the third party libraries build systems have been updated to target CentOS 7
Stefano Bonicatti
04/08/2025, 6:14 PMAnd actually, I also forgot, the CI environment for Linux is in Docker, which still uses a fixed version of Ubuntu 20.04.
So it will be a bit of a mixed environment; newer kernel but same userspace.
z
zwass
04/08/2025, 6:17 PM
I did leave self hosted runners on 20.04 (https://github.com/osquery/osquery/blob/master/.github/workflows/self_hosted_runners.yml#L43) as I thought that might not be a trivial change. Not sure if it needs addressing as well?
s
Stefano Bonicatti
04/08/2025, 6:18 PMOh right, that's still a github hosted runner
Stefano Bonicatti
04/08/2025, 6:19 PMthe self hosted part comes later
z
zwass
04/08/2025, 6:19 PM
Oh I see that now
zwass
04/08/2025, 6:20 PM
Okay so that should be addressed as well
zwass
04/08/2025, 6:22 PM
k can you re-approve please?
zwass
04/08/2025, 8:34 PM
Unfortunately looks like some tests fail on ubuntu 22.