Title
#core
theopolis

theopolis

12/21/2020, 2:25 PM
Hey folks, I'm in favor of a 4.6.1 tag at https://github.com/osquery/osquery/commit/90c981a0e9a76f87f30887dba7ce6f8c65039ce1 since the non-portability of Windows can be a show stopper. If no one opposes then I can handle the TODOs later this afternoon.
terracatta

terracatta

12/21/2020, 2:58 PM
Would be lovely if we could include the filevault and office_mru documentation fix as well. But I totally understand if you can't include those commits.
Stefano Bonicatti

Stefano Bonicatti

12/21/2020, 4:39 PM
Those have been already merged 🙂
4:42 PM
oups I misread Teddy
a

alessandrogario

12/21/2020, 10:39 PM
We have merged a pretty big refactor after 4.6.0, I'd create a new 4.6.1 branch based on the 4.6.0 tag and import the fix there rather than starting from master
s

seph

12/22/2020, 12:57 AM
So the goal is to allow people to build 4.6.1 releases from windows, who wouldn’t be building off
HEAD
?
12:58 AM
Feels odd given the complains that builds don’t work off the source tarballs, since the
git describe
invocation is broken
12:58 AM
But that’s a weakly held opinion
theopolis

theopolis

12/22/2020, 2:55 AM
We could also rebuild the 4.6.0 msi/zip/nupkg and set the value of
CMAKE_MSVC_RUNTIME_LIBRARY
on the command line
2:56 AM
On linux I would increment the package build revision to
-2.linux
but I am not sure this revision metadata exists.
3:22 AM
I'm going to explore this route with @thor tomorrow. Seems the easiest / most sensical.
thor

thor

12/22/2020, 3:23 AM
Sounds good, 👍