Hey folks I m in favor of a 4 6 1 tag at

Question

Hey folks I m in favor of a 4 6 1 tag at <https github com osquery osquery commit 90c981a0e9a76f87f30887dba7ce6f8c65039ce1> since the non portability of Windows can be a show stopper If no one opposes then I can handle the TODOs later this afternoon

terracatta · Answer

Would be lovely if we could include the filevault and office mru documentation fix as well But I totally understand if you can t include those commits

Stefano Bonicatti · Answer

Those have been already merged slightly smiling face

Stefano Bonicatti · Answer

oups I misread Teddy

alessandrogario · Answer

We have merged a pretty big refactor after 4 6 0 I d create a new 4 6 1 branch based on the 4 6 0 tag and import the fix there rather than starting from master

seph · Answer

So the goal is to allow people to build 4 6 1 releases from windows who wouldn t be building off `HEAD`

seph · Answer

Feels odd given the complains that builds don t work off the source tarballs since the `git describe` invocation is broken

seph · Answer

But that s a weakly held opinion

theopolis · Answer

We could also rebuild the 4 6 0 msi zip nupkg and set the value of `CMAKE MSVC RUNTIME LIBRARY` on the command line

theopolis · Answer

On linux I would increment the package build revision to ` 2 linux` but I am not sure this revision metadata exists

theopolis · Answer

I m going to explore this route with < thor> tomorrow Seems the easiest most sensical

thor · Answer

Sounds good thumbsup