Title
#code-review
s

seph

05/02/2022, 11:42 PM
Y’all have a bunch of approved PRs hanging out. I think you could sweep through and merge them. I probably will eventually
Mike Myers

Mike Myers

05/03/2022, 8:21 PM
I think the approved stuff is targeted for 5.4.0 for whatever reason, after we tag 5.3
8:21 PM
@Stefano Bonicatti wanted to change something in 7502? But we could merge 7492 now if that's okay with him?
Stefano Bonicatti

Stefano Bonicatti

05/04/2022, 12:54 PM
So for 7502, I think it’s worth to have it work also “detached” from the watchdog, meaning that it will use a MBs target instead of a % of watchdog memory limit (besides the default value). The “risk” I was worried about is pretty low. I was also waiting on https://github.com/osquery/osquery/pull/7561 even if it’s approved because maybe we should first give a more official/public announcement for it. I re-thinked seph’s comment about it breaking some things and last time, in the moment, I didn’t recall how many flags are actually CLI_FLAGS, so there’s a high chance that people are setting one of those flags via the config file erroneously, and even though they’ll get a WARNING, osquery won’t work as expected.
s

seph

05/04/2022, 1:36 PM
If we wanted to phase in 7561, we could emits warnings for a release, then enforce in a future one