Title
#code-review
puffycid

puffycid

02/17/2020, 12:31 AM
Could someone take one last review at:https://github.com/osquery/osquery/pull/5539 I believe all issues have been resolved Once its merged I can update https://github.com/osquery/osquery/pull/5831 In addition once its merged I can open another PR that adds support for appcomapt/shimcache for windows Thanks!
s

seph

02/27/2020, 3:49 AM
@thor? You looked at this about a month ago, saying it looked good, but you wanted to let others comment. Teddy’s got some refactoring comments, but I don’t know that they’re blocking. I feel like rot13 should be in util somewhere, but also, NBD… What to make a call?