Title
#code-review
Garret

Garret

11/19/2019, 9:55 PM
If I could get a review on https://github.com/osquery/osquery/pull/5981 I'd be grateful -- Teddy has already very kindly taken the time to go over it a couple times and I've addressed the comments (and gotten it back to passing tests)
theopolis

theopolis

11/19/2019, 11:04 PM
it looks good to go mostly, I can make some changes to the CMake code (it looks like the indents at 4 when they are typically 2.
s

seph

11/20/2019, 3:09 AM
Seems okay to me. I had one question, but I’m pretty sure the answer is yes. I’ll thumb it, and leave it for Teddy to merge if he’s happy
Garret

Garret

11/20/2019, 6:54 PM
oh, that's a good catch, the ordering is now predictable
s

seph

11/20/2019, 8:04 PM
Sweet! Thanks for fixing that