Title
#kolide
s

seph

03/05/2019, 4:20 PM
@defensivedepth That’s over a week old. That branch (including the fix for that error) merged in https://github.com/kolide/launcher/pull/415 For package-builder, you really want HEAD and not anything in the releases.
defensivedepth

defensivedepth

03/05/2019, 4:26 PM
thanks @seph I will try again later today with HEAD
7:53 PM
@seph Build was successful and install on Win10 worked... thanks for your hard work on this!
s

seph

03/05/2019, 7:53 PM
Sweeeet!
7:54 PM
Did you build one with a service? That’s probably the first not-seph test of it
defensivedepth

defensivedepth

03/05/2019, 7:54 PM
Yes, and the service install worked just fine
s

seph

03/05/2019, 7:54 PM
Awesome! The code behind it is kinda gnarly
7:55 PM
So I’m glad it worked
defensivedepth

defensivedepth

03/05/2019, 7:55 PM
Will do a bit more testing on it over the next few days
s

seph

03/05/2019, 7:56 PM
I’m happy to hear feedback. I know it’s still a moving target, but it’s great that it’s working
defensivedepth

defensivedepth

03/05/2019, 8:01 PM
Assuming that osquery in-place upgrade already works? It was just the packaging into an MSI that was the issue, correct?
s

seph

03/05/2019, 8:03 PM
that's my assumption, but i haven't tested it at all
m

mbmy

03/06/2019, 1:03 AM
I am about to dig in and try the same on a Windows box, so I will let you know if I have the same result (assuming I can figure out building it on Windows)
4:52 AM
😁 thanks @seph!
4:54 AM
one thing i noticed after installing is that the agent partially checked in while showing the service as running but never actually signed up completely. i waited a few minutes and restarted the service and it completed the signup
5:04 AM
not sure if it's a race condition when starting the service initially after install but it's launching properly on reboot and connecting.
5:07 AM
these were my arguments if useful:
5:07 AM
.\build\package-builder.exe make --autoupdate --debug --enroll_secret="secret" --identifier=kolide --launcher_version=nightly --osquery_version=stable --targets=windows-service-msi --output_dir=c:\windows\temp\kolide_pkgs\ --hostname=<http://example.com:443|example.com:443>